Skip to content

Bump minimum Julia version to 1.10.8 (?) #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 9, 2025
Merged

Bump minimum Julia version to 1.10.8 (?) #979

merged 3 commits into from
Jul 9, 2025

Conversation

penelopeysm
Copy link
Member

@penelopeysm penelopeysm commented Jul 9, 2025 •
edited
Loading

This PR attempts to fix the CI crash observed on 1.10.0. The current knowledge is:

Note that the runtime crash seems very similar to this one TuringLang/Bijectors.jl#368.

In that PR, the agreed-upon solution was to increase Julia compat to 1.10.8, so I've done the same here. It's not a perfect solution by any means but IMO it's the least bad option.

I have zero clue which part of Julia 1.10.8 fixed it, although this seems like the most likely one to me JuliaLang/julia@964fdf0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2025 •
edited
Loading

Benchmark Report for Commit 07b672b

Computer Information

Julia Version 1.11.5
Commit 760b2e5b739 (2025-04-14 06:53 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
  CPU: 4 × AMD EPYC 7763 64-Core Processor
  WORD_SIZE: 64
  LLVM: libLLVM-16.0.6 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Benchmark Results

|                 Model | Dimension |  AD Backend |      VarInfo Type | Linked | Eval Time / Ref Time | AD Time / Eval Time |
|-----------------------|-----------|-------------|-------------------|--------|----------------------|---------------------|
| Simple assume observe |         1 | forwarddiff |             typed |  false |                 10.5 |                 1.4 |
|           Smorgasbord |       201 | forwarddiff |             typed |  false |                752.1 |                35.7 |
|           Smorgasbord |       201 | forwarddiff | simple_namedtuple |   true |                305.5 |                69.0 |
|           Smorgasbord |       201 | forwarddiff |           untyped |   true |               1271.4 |                26.8 |
|           Smorgasbord |       201 | forwarddiff |       simple_dict |   true |               3373.4 |                23.4 |
|           Smorgasbord |       201 | reversediff |             typed |   true |               1520.3 |                29.0 |
|           Smorgasbord |       201 |    mooncake |             typed |   true |                977.9 |                 5.4 |
|    Loop univariate 1k |      1000 |    mooncake |             typed |   true |               5579.7 |                 4.1 |
|       Multivariate 1k |      1000 |    mooncake |             typed |   true |               1039.8 |                 8.8 |
|   Loop univariate 10k |     10000 |    mooncake |             typed |   true |              62680.5 |                 3.7 |
|      Multivariate 10k |     10000 |    mooncake |             typed |   true |               8835.6 |                 9.8 |
|               Dynamic |        10 |    mooncake |             typed |   true |                132.6 |                13.6 |
|              Submodel |         1 |    mooncake |             typed |   true |                 14.3 |                 6.6 |
|                   LDA |        12 | reversediff |             typed |   true |                470.0 |                 7.0 |

@codecov Codecov
Copy link

codecov bot commented Jul 9, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.97%. Comparing base (acac44d) to head (07b672b).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #979      +/-   ##
==========================================
- Coverage   83.00%   82.97%   -0.03%     
==========================================
  Files          36       36              
  Lines        3965     3965              
==========================================
- Hits         3291     3290       -1     
- Misses        674      675       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls
Copy link

coveralls commented Jul 9, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 16170022314

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 83.144%
Files with Coverage Reduction New Missed Lines %
src/compiler.jl 1 87.56%
Totals Coverage Status
Change from base Build 16115950849: -0.03%
Covered Lines: 3290
Relevant Lines: 3957
💛 - Coveralls

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2025

DynamicPPL.jl documentation for PR #979 is available at:
https://TuringLang.github.io/DynamicPPL.jl/previews/PR979/

@penelopeysm penelopeysm changed the title attempt to isolate Julia 1.10 test crash Bump minimum Julia version to 1.10.8 (?) Jul 9, 2025
@penelopeysm penelopeysm marked this pull request as ready for review July 9, 2025 12:59
@penelopeysm penelopeysm mentioned this pull request Jul 9, 2025
Closed
mhauru
mhauru approved these changes Jul 9, 2025
View reviewed changes
Copy link
Member

@mhauru mhauru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@penelopeysm penelopeysm added this pull request to the merge queue Jul 9, 2025
Merged via the queue into main with commit b4ee208 Jul 9, 2025
20 of 21 checks passed
@penelopeysm penelopeysm deleted the py/fix-mooncake branch July 9, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhauru mhauru mhauru approved these changes

Assignees

@penelopeysm penelopeysm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@penelopeysm @coveralls @mhauru